Messages in this thread Patch in this message | | | From | Arvind Yadav <> | Subject | [PATCH] kernel: cpu: hotplug: constify attribute_group structures. | Date | Thu, 29 Jun 2017 17:40:47 +0530 |
| |
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by <linux/sysfs.h> work with const attribute_group. So mark the non-const structs as const.
File size before: text data bss dec hex filename 12582 15361 20 27963 6d3b kernel/cpu.o
File size After adding 'const': text data bss dec hex filename 12710 15265 20 27995 6d5b kernel/cpu.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- kernel/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/cpu.c b/kernel/cpu.c index 9ae6fbe..45455f9 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -1684,7 +1684,7 @@ static ssize_t show_cpuhp_target(struct device *dev, NULL }; -static struct attribute_group cpuhp_cpu_attr_group = { +static const struct attribute_group cpuhp_cpu_attr_group = { .attrs = cpuhp_cpu_attrs, .name = "hotplug", NULL @@ -1716,7 +1716,7 @@ static ssize_t show_cpuhp_states(struct device *dev, NULL }; -static struct attribute_group cpuhp_cpu_root_attr_group = { +static const struct attribute_group cpuhp_cpu_root_attr_group = { .attrs = cpuhp_cpu_root_attrs, .name = "hotplug", NULL -- 1.9.1
| |