Messages in this thread Patch in this message | | | Date | Wed, 28 Jun 2017 14:13:00 -0700 (PDT) | From | Palmer Dabbelt <> | Subject | Re: [PATCH 9/9] RISC-V: Build Infastructure |
| |
On Wed, 28 Jun 2017 14:05:14 PDT (-0700), merker@debian.org wrote: > On Wed, Jun 28, 2017 at 11:55:38AM -0700, Palmer Dabbelt wrote: >> This patch contains all the build infastructure that actually enables >> the RISC-V port. This includes Makefiles, linker scripts, and Kconfig >> files. It also contains the only top-level change, which adds RISC-V to >> the list of architectures that need a sed run to produce the ARCH >> variable when building locally. >> >> Signed-off-by: Palmer Dabbelt <palmer@dabbelt.com> >> --- > [...] >> diff --git a/arch/riscv/configs/freedom-u500_defconfig b/arch/riscv/configs/freedom-u500_defconfig >> new file mode 100644 >> index 000000000000..b37908d45067 >> --- /dev/null >> +++ b/arch/riscv/configs/freedom-u500_defconfig >> @@ -0,0 +1,53 @@ >> +CONFIG_CROSS_COMPILE="riscv64-unknown-linux-gnu-" > > just a tiny nitpick: defconfigs shouldn't predefine a crosscompiler > prefix. That has already been fixed in the other defconfigs at > some earlier point in time, but IIRC the freedom-u500_defconfig got > added later on and it was probably overlooked then.
Oh, sorry about that -- you're right, I just missed that one as it wasn't in the original patch set.
I'll squash this in when we do a v4.
commit 1a262894827be647d55016da09f61eb49962dd7d Author: Palmer Dabbelt <palmer@dabbelt.com> Date: Wed Jun 28 14:11:17 2017 -0700
Don't define CROSS_COMPILE in the u500 defconfig
diff --git a/arch/riscv/configs/freedom-u500_defconfig b/arch/riscv/configs/freedom-u500_defconfig index b37908d45067..b580dc5c8feb 100644 --- a/arch/riscv/configs/freedom-u500_defconfig +++ b/arch/riscv/configs/freedom-u500_defconfig @@ -1,4 +1,3 @@ -CONFIG_CROSS_COMPILE="riscv64-unknown-linux-gnu-" CONFIG_DEFAULT_HOSTNAME="ucbvax" # CONFIG_CROSS_MEMORY_ATTACH is not set # CONFIG_FHANDLE is not set
| |