Messages in this thread | | | Subject | Re: [RESEND PATCH v4 1/3] Bluetooth: bnep: fix possible might sleep error in bnep_session | From | Marcel Holtmann <> | Date | Tue, 27 Jun 2017 19:32:52 +0200 |
| |
Hi Jeffy,
> It looks like bnep_session has same pattern as the issue reported in > old rfcomm: > > while (1) { > set_current_state(TASK_INTERRUPTIBLE); > if (condition) > break; > // may call might_sleep here > schedule(); > } > __set_current_state(TASK_RUNNING); > > Which fixed at: > dfb2fae Bluetooth: Fix nested sleeps > > So let's fix it at the same way, also follow the suggestion of: > https://lwn.net/Articles/628628/ > > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> > Reviewed-by: Brian Norris <briannorris@chromium.org> > Reviewed-by: AL Yu-Chen Cho <acho@suse.com> > --- > > Changes in v4: None > Changes in v2: None > > net/bluetooth/bnep/core.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-)
all 3 patches have been applied to bluetooth-next tree.
Regards
Marcel
| |