lkml.org 
[lkml]   [2017]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fortify: Avoid panic() in favor of BUG()
Hi Kees,

[auto build test WARNING on next-20170619]
[cannot apply to linus/master linux/master v4.12-rc6 v4.12-rc5 v4.12-rc4 v4.12-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Kees-Cook/fortify-Avoid-panic-in-favor-of-BUG/20170627-230653
config: sh-allyesconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sh

All warnings (new ones prefixed by >>):

lib/string.c: In function 'fortify_panic':
>> lib/string.c:986:1: warning: 'noreturn' function does return
}
^

vim +/noreturn +986 lib/string.c

94df2904 Rasmus Villemoes 2015-06-25 970 *
94df2904 Rasmus Villemoes 2015-06-25 971 * Returns pointer to the nul byte at the end of @s.
94df2904 Rasmus Villemoes 2015-06-25 972 */
94df2904 Rasmus Villemoes 2015-06-25 973 char *strreplace(char *s, char old, char new)
94df2904 Rasmus Villemoes 2015-06-25 974 {
94df2904 Rasmus Villemoes 2015-06-25 975 for (; *s; ++s)
94df2904 Rasmus Villemoes 2015-06-25 976 if (*s == old)
94df2904 Rasmus Villemoes 2015-06-25 977 *s = new;
94df2904 Rasmus Villemoes 2015-06-25 978 return s;
94df2904 Rasmus Villemoes 2015-06-25 979 }
94df2904 Rasmus Villemoes 2015-06-25 980 EXPORT_SYMBOL(strreplace);
b90d6eba Daniel Micay 2017-06-06 981
b90d6eba Daniel Micay 2017-06-06 982 void fortify_panic(const char *name)
b90d6eba Daniel Micay 2017-06-06 983 {
8a94b337 Kees Cook 2017-06-26 984 pr_emerg("detected buffer overflow in %s\n", name);
8a94b337 Kees Cook 2017-06-26 985 BUG();
b90d6eba Daniel Micay 2017-06-06 @986 }
b90d6eba Daniel Micay 2017-06-06 987 EXPORT_SYMBOL(fortify_panic);

:::::: The code at line 986 was first introduced by commit
:::::: b90d6eba50d76750576dc8afe5eaa43974a1f17f include/linux/string.h: add the option of fortified string.h functions

:::::: TO: Daniel Micay <danielmicay@gmail.com>
:::::: CC: Kees Cook <keescook@chromium.org>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2017-06-27 17:54    [W:0.041 / U:0.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site