lkml.org 
[lkml]   [2017]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v8 RESEND 07/38] x86/mm: Remove phys_to_virt() usage in ioremap()
    Date
    Currently there is a check if the address being mapped is in the ISA
    range (is_ISA_range()), and if it is, then phys_to_virt() is used to
    perform the mapping. When SME is active, the default is to add pagetable
    mappings with the encryption bit set unless specifically overridden. The
    resulting pagetable mapping from phys_to_virt() will result in a mapping
    that has the encryption bit set. With SME, the use of ioremap() is
    intended to generate pagetable mappings that do not have the encryption
    bit set through the use of the PAGE_KERNEL_IO protection value.

    Rather than special case the SME scenario, remove the ISA range check and
    usage of phys_to_virt() and have ISA range mappings continue through the
    remaining ioremap() path.

    Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
    ---
    arch/x86/mm/ioremap.c | 7 +------
    1 file changed, 1 insertion(+), 6 deletions(-)

    diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
    index 4c1b5fd..bfc3e2d 100644
    --- a/arch/x86/mm/ioremap.c
    +++ b/arch/x86/mm/ioremap.c
    @@ -13,6 +13,7 @@
    #include <linux/slab.h>
    #include <linux/vmalloc.h>
    #include <linux/mmiotrace.h>
    +#include <linux/mem_encrypt.h>

    #include <asm/set_memory.h>
    #include <asm/e820/api.h>
    @@ -106,12 +107,6 @@ static void __iomem *__ioremap_caller(resource_size_t phys_addr,
    }

    /*
    - * Don't remap the low PCI/ISA area, it's always mapped..
    - */
    - if (is_ISA_range(phys_addr, last_addr))
    - return (__force void __iomem *)phys_to_virt(phys_addr);
    -
    - /*
    * Don't allow anybody to remap normal RAM that we're using..
    */
    pfn = phys_addr >> PAGE_SHIFT;
    \
     
     \ /
      Last update: 2017-06-27 17:12    [W:4.473 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site