Messages in this thread | | | Date | Tue, 27 Jun 2017 21:46:47 +0930 | From | Jonathan Woithe <> | Subject | Re: [PATCH 1/7] platform/x86: fujitsu-laptop: do not use kfifo for storing hotkey scancodes |
| |
On Mon, Jun 26, 2017 at 05:07:18PM -0700, Darren Hart wrote: > On Sat, Jun 24, 2017 at 02:25:46AM +0200, Rafael Wysocki wrote: > > > Rafael, the above rationale appears sound to me. Do you have any concerns? > > > > I actually do. > > > > While this is the case today, making the driver code depend on it in a hard way > > sort of makes it difficult to change in the future if need be. > > OK, if we aren't guaranteed for this to run on CPU 0 in the future, and > this will be annoying to debug if it does changes, let's skip the kfifo > change. > > I have removed this patch, and fixed up the merge conflicts of the > remaining 6 patches here: > > http://git.infradead.org/linux-platform-drivers-x86.git/shortlog/refs/heads/fujitsu > > Michal / Jonathan, would you please review and let me know if this is what > you would have done / approve the rebase?
The rebase looks reasonable to me.
Regards jonathan
| |