Messages in this thread | | | From | Brendan Higgins <> | Date | Tue, 27 Jun 2017 16:47:45 -0700 | Subject | Re: [PATCH v11 3/4] i2c: aspeed: added driver for Aspeed I2C |
| |
On Tue, Jun 27, 2017 at 2:00 AM, Wolfram Sang <wsa@the-dreams.de> wrote: > >> > If SCL is stuck low, how do you want to send a STOP? >> > >> >> Fair point. I should probably drop that in the future and just do a >> reset, and even then, doing a >> reset is probably just wishful thinking. If a slave is holding down >> SCL, we are pretty screwed. > > Yes, you'd need to reset the client device. And that has to be done in > the client driver. I wonder if i2c_transfer and friends should return a > specific error value in that case... need to think about it. >
Well, a good first step would be to make my recovery code conform to the struct i2c_bus_recovery_info. Is i2c_generic_scl_recovery supposed to be part of the user interface, or is it just intended to help put the main recovery function together?
| |