Messages in this thread | | | Date | Tue, 27 Jun 2017 23:16:10 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH 1/4] i2c: add helpers to ease DMA handling |
| |
Hi Geert,
> > +static inline int i2c_check_msg_for_dma(struct i2c_msg *msg, unsigned int threshold, > > + u8 **ptr_for_bounce_buf) > > __must_check?
Yes, why not.
> Isn't this function a bit large to be inlined?
That can be argued, yes. But I am unsure to bloat the core if the function is so rarely needed...
> > +static inline void i2c_release_bounce_buf(struct i2c_msg *msg, u8 *bounce_buf) > > This one is smaller.
Yup, but of course, they should be put in the same place, whereever that may be.
Thanks,
Wolfram
[unhandled content-type:application/pgp-signature] | |