Messages in this thread | | | From | Logan Gunthorpe <> | Date | Mon, 26 Jun 2017 15:25:41 -0600 | Subject | Re: [PATCH 2/7] iomap: implement ioread64 and iowrite64 |
| |
On 6/26/2017 2:43 PM, Arnd Bergmann wrote: > This hardcodes the behavior of include/linux/io-64-nonatomic-hi-lo.h, which > I find rather confusing, as only about one in five drivers wants this > behavior. > > I'd suggest you don't add it in lib/iomap.c at all for 32-bit architectures, > but rather use the same logic that we have for readq/writeq in > io-64-nonatomic-hi-lo.h and io-64-nonatomic-lo-hi.h, adding > {lo_hi,hi_lo}_{ioread,iowrite}{,be} to the same files, and provide > the {ioread,iowrite}{,be} macros only if they have not been defined > at that point.
Thanks Arnd. Yes, I'm already reworking this patchset to do exactly that.
Logan
| |