Messages in this thread | | | Subject | Re: [PATCH net-next v2 4/5] net: add netlink_ext_ack argument to rtnl_link_ops.slave_changelink | From | Matthias Schiffer <> | Date | Mon, 26 Jun 2017 15:45:31 +0200 |
| |
On 06/26/2017 03:33 PM, David Ahern wrote: > On 6/26/17 2:43 AM, Matthias Schiffer wrote: >> On 06/26/2017 06:08 AM, David Ahern wrote: >>> On 6/25/17 10:04 PM, David Ahern wrote: >>>> On 6/25/17 3:56 PM, Matthias Schiffer wrote: >>>>> Add support for extended error reporting. >>>>> >>>>> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net> >>>>> --- >>>> >>>> >>>> Acked-by: David Ahern <dsahern@gmail.com> >>>> >>> >>> Actually, you are missing the chagne to br_port_slave_changelink. >>> >> >> I'm confused. I am changing br_port_slave_changelink? All my patches are >> compile-tested. >> > > You are changing the signature of slave_changelink, no? > > net/bridge/br_netlink.c: > .slave_changelink = br_port_slave_changelink, >
Please read my patch again, I *am* changing br_port_slave_changelink to match the new signature (this is the net/bridge/br_netlink.c change appearing in the diffstat).
[unhandled content-type:application/pgp-signature] | |