Messages in this thread | | | Subject | Re: [RFC PATCH 1/2] crypto: caam - properly set IV after {en,de}crypt | From | David Gstir <> | Date | Mon, 26 Jun 2017 07:40:58 +0200 |
| |
Herbert,
> On 20 Jun 2017, at 03:28, Herbert Xu <herbert@gondor.apana.org.au> wrote: > > On Mon, Jun 19, 2017 at 10:31:27AM +0000, Horia Geantă wrote: >> >> IIUC, IV update is required only in case of CBC. >> Since this callback is used also for CTR, we should avoid the copy: >> if ((ctx->cdata.algtype & OP_ALG_AAI_MASK) == OP_ALG_AAI_CBC) ... > > No it is needed for CTR too.
So, am I correct in assuming that it is required for all modes including AEAD modes like GCM? In that case I'll include a fix for the CAAM GCM mode too.
Thanks, David
| |