lkml.org 
[lkml]   [2017]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] staging: sm750fb: always take the lock
On Mon, Jun 26, 2017 at 11:11 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Mon, Jun 26, 2017 at 7:45 AM, AbdAllah-MEZITI
> <abdallah.meziti.pro@gmail.com> wrote:
>> This patch
>> - will always take the lock
>
> Why?
>
> "The current code only takes the lock if multiple instances are in use.
> This is error-prone, and confuses static analyzers.
> As taking the lock in case of a single instance is harmful and cheap,
> change the code to always take the lock."

I would argue that it's not harmful, lest people get confused about
it. And I agree that this explanation is much more useful than just
mentioning the warnings that you saw.

Thanks,
Frans

\
 
 \ /
  Last update: 2017-06-26 11:16    [W:0.088 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site