lkml.org 
[lkml]   [2017]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][spi-next] spi: stm32: fix range limit checks on div
From
Date

On 06/22/2017 05:41 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the check for range limits on div is incorrect and will
> never return -EINVAL. Fix this by replacing && with ||
>
> Detected by CoverityScan, CID#1446580 ("Structurally dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/spi/spi-stm32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c
> index 0553f61ab3b7..b75909e7b117 100644
> --- a/drivers/spi/spi-stm32.c
> +++ b/drivers/spi/spi-stm32.c
> @@ -262,7 +262,7 @@ static int stm32_spi_prepare_mbr(struct stm32_spi *spi, u32 speed_hz)
> * no need to check it there.
> * However, we need to ensure the following calculations.
> */
> - if ((div < SPI_MBR_DIV_MIN) &&
> + if ((div < SPI_MBR_DIV_MIN) ||
> (div > SPI_MBR_DIV_MAX))
> return -EINVAL;
>
>

Reviewed-by: Amelie Delaunay <amelie.delaunay@st.com>

\
 
 \ /
  Last update: 2017-06-23 14:43    [W:0.063 / U:25.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site