lkml.org 
[lkml]   [2017]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kernel/extable.c: mark core_kernel_text notrace
On Thu, 22 Jun 2017, Steven Rostedt wrote:
> On Wed, 21 Jun 2017 09:03:26 +0200
> Marcin Nowakowski <marcin.nowakowski@imgtec.com> wrote:
> >
> > -int core_kernel_text(unsigned long addr)
> > +int notrace core_kernel_text(unsigned long addr)
>
> Is mips the only one with this issue. I hate adding notrace to general
> functions if it is only an issue with a single arch.

We have unwinders using that function and btw, ftrace has a similar issue
with core_kernel_data(). Probably not endless recursive, but not pretty
either if you have trace entries from within the tracer itself.

> Can we add a: mips_notrace? where we have:
>
> #ifdef CONFIG_MIPS
> # define mips_notrace notrace
> #else
> # define mips_notrace
> #endif

We can, but that will explode into an unholy mess sooner than later. I know
you'd love to come up with the most convoluted macro magic to make that
happen.

Thanks,

tglx

\
 
 \ /
  Last update: 2017-06-23 00:17    [W:1.433 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site