lkml.org 
[lkml]   [2017]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Check return value from call to core->write(), so in case of
    error print error message, jump to goto label fail and eventually
    return.

    Addresses-Coverity-ID: 1226943
    Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
    ---
    drivers/media/radio/radio-wl1273.c | 15 +++++++++++++--
    1 file changed, 13 insertions(+), 2 deletions(-)

    diff --git a/drivers/media/radio/radio-wl1273.c b/drivers/media/radio/radio-wl1273.c
    index 7240223..17e82a9 100644
    --- a/drivers/media/radio/radio-wl1273.c
    +++ b/drivers/media/radio/radio-wl1273.c
    @@ -610,10 +610,21 @@ static int wl1273_fm_start(struct wl1273_device *radio, int new_mode)
    }
    }

    - if (radio->rds_on)
    + if (radio->rds_on) {
    r = core->write(core, WL1273_RDS_DATA_ENB, 1);
    - else
    + if (r) {
    + dev_err(dev, "%s: RDS_DATA_ENB ON fails\n",
    + __func__);
    + goto fail;
    + }
    + } else {
    r = core->write(core, WL1273_RDS_DATA_ENB, 0);
    + if (r) {
    + dev_err(dev, "%s: RDS_DATA_ENB OFF fails\n",
    + __func__);
    + goto fail;
    + }
    + }
    } else {
    dev_warn(dev, "%s: Illegal mode.\n", __func__);
    }
    --
    2.5.0
    \
     
     \ /
      Last update: 2017-06-22 20:00    [W:2.519 / U:0.792 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site