Messages in this thread Patch in this message | | | Date | Wed, 21 Jun 2017 11:51:09 -0400 | From | Dennis Zhou <> | Subject | [PATCH 1/1] percpu: resolve err may not be initialized in pcpu_alloc |
| |
From 4a42ecc735cff0015cc73c3d87edede631f4b885 Mon Sep 17 00:00:00 2001 From: Dennis Zhou <dennisz@fb.com> Date: Wed, 21 Jun 2017 08:07:15 -0700
Add error message to out of space failure for atomic allocations in percpu allocation path to fix -Wmaybe-uninitialized.
Signed-off-by: Dennis Zhou <dennisz@fb.com> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> --- mm/percpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mm/percpu.c b/mm/percpu.c index a5bc363..bd4130a 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -956,8 +956,10 @@ static void __percpu *pcpu_alloc(size_t size, size_t align, bool reserved, * tasks to create chunks simultaneously. Serialize and create iff * there's still no empty chunk after grabbing the mutex. */ - if (is_atomic) + if (is_atomic) { + err = "atomic alloc failed, no space left"; goto fail; + } if (list_empty(&pcpu_slot[pcpu_nr_slots - 1])) { chunk = pcpu_create_chunk(); -- 2.9.3
| |