Messages in this thread | | | From | Milian Wolff <> | Subject | Re: [PATCH v2] perf: libdw support for powerpc [ping] | Date | Wed, 21 Jun 2017 10:16:56 +0200 |
| |
On Mittwoch, 21. Juni 2017 03:07:39 CEST Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 15, 2017 at 10:46:16AM +0200, Milian Wolff escreveu: > > On Tuesday, June 13, 2017 5:55:09 PM CEST Ravi Bangoria wrote: > > Just a quick question: Have you guys applied my recent patch: > > > > commit 5ea0416f51cc93436bbe497c62ab49fd9cb245b6 > > Author: Milian Wolff <milian.wolff@kdab.com> > > Date: Thu Jun 1 23:00:21 2017 +0200 > > > > perf report: Include partial stacks unwound with libdw > > > > So far the whole stack was thrown away when any error occurred before > > the maximum stack depth was unwound. This is actually a very common > > scenario though. The stacks that got unwound so far are still > > interesting. This removes a large chunk of differences when comparing > > perf script output for libunwind and libdw perf unwinding. > > > > If not, then this could explain the issue you are seeing. > > Hi Millian, can I take this as an Acked-by or Tested-by?
I have no access to any PowerPC hardware. In principle the code looks fine, but that's all I can say here.
Cheers
-- Milian Wolff | milian.wolff@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH&Co KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts
| |