lkml.org 
[lkml]   [2017]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] writeback: Rework wb_[dec|inc]_stat family of functions
Hello, Nikolay.

On Tue, Jun 20, 2017 at 09:02:00PM +0300, Nikolay Borisov wrote:
> Currently the writeback statistics code uses a percpu counters to hold
> various statistics. Furthermore we have 2 families of functions - those which
> disable local irq and those which doesn't and whose names begin with
> double underscore. However, they both end up calling __add_wb_stats which in
> turn calls percpu_counter_add_batch which is already irq-safe.

Heh, looks like I was confused. __percpu_counter_add() is not
irq-safe. It disables preemption and uses __this_cpu_read(), so
there's no protection against irq. If writeback statistics want
irq-safe operations and it does, it would need these separate
operations. Am I missing something?

Thanks.

--
tejun

\
 
 \ /
  Last update: 2017-06-20 21:38    [W:0.044 / U:0.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site