lkml.org 
[lkml]   [2017]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 4/6] irqchip: irq-mvebu-icu: new driver for Marvell ICU
From
Date
On 20/06/17 15:09, Thomas Petazzoni wrote:
> Hello,
>
> On Tue, 20 Jun 2017 15:00:19 +0100, Marc Zyngier wrote:
>
>> There is a few things: this driver could (mostly) work with a GICv3
>> distributor (located way above 4GB) instead of the GICP, and I'd rather
>> make no assumption of where GICP is located in the memory map.
>>
>> So I'd rather see:
>>
>> if (msg->address_lo || msg->address_hi) {
>> [...]
>> } else {
>> /* deconfiguration case */
>> }
>
> Ha, OK, indeed. /me feels stupid now.
>
> Unfortunately, I just sent v4 a few minutes ago. I'll wait for you to
> look at this v4. If there's nothing else to be changed, then I'll send
> a v5 with just this change.

If that's the only thing, I can apply the fixlet locally.

Thanks,

M.
--
Jazz is not dead. It just smells funny...

\
 
 \ /
  Last update: 2017-06-20 16:15    [W:0.046 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site