Messages in this thread | | | Subject | Re: [PATCH v3 4/6] irqchip: irq-mvebu-icu: new driver for Marvell ICU | From | Marc Zyngier <> | Date | Tue, 20 Jun 2017 15:14:41 +0100 |
| |
On 20/06/17 15:09, Thomas Petazzoni wrote: > Hello, > > On Tue, 20 Jun 2017 15:00:19 +0100, Marc Zyngier wrote: > >> There is a few things: this driver could (mostly) work with a GICv3 >> distributor (located way above 4GB) instead of the GICP, and I'd rather >> make no assumption of where GICP is located in the memory map. >> >> So I'd rather see: >> >> if (msg->address_lo || msg->address_hi) { >> [...] >> } else { >> /* deconfiguration case */ >> } > > Ha, OK, indeed. /me feels stupid now. > > Unfortunately, I just sent v4 a few minutes ago. I'll wait for you to > look at this v4. If there's nothing else to be changed, then I'll send > a v5 with just this change.
If that's the only thing, I can apply the fixlet locally.
Thanks,
M. -- Jazz is not dead. It just smells funny...
| |