lkml.org 
[lkml]   [2017]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] PCI / ACPI / PM: Avoid disabling wakeup for bridges too early
Hi Rafael,

[auto build test WARNING on pm/linux-next]
[also build test WARNING on next-20170620]
[cannot apply to v4.12-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Rafael-J-Wysocki/PM-Unify-the-handling-of-device-wakeup-settings/20170620-195729
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-randconfig-x019-201725 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

drivers/acpi/device_pm.c: In function '__acpi_pm_device_wakeup':
>> drivers/acpi/device_pm.c:735:6: warning: 'error' may be used uninitialized in this function [-Wmaybe-uninitialized]
int error;
^~~~~

vim +/error +735 drivers/acpi/device_pm.c

235d81a6 Rafael J. Wysocki 2017-06-12 719 } else if (adev->wakeup.flags.enabled) {
dee8370c Rafael J. Wysocki 2012-11-02 720 acpi_disable_gpe(wakeup->gpe_device, wakeup->gpe_number);
dee8370c Rafael J. Wysocki 2012-11-02 721 acpi_disable_wakeup_device_power(adev);
235d81a6 Rafael J. Wysocki 2017-06-12 722 adev->wakeup.flags.enabled = 0;
dee8370c Rafael J. Wysocki 2012-11-02 723 }
dee8370c Rafael J. Wysocki 2012-11-02 724 return 0;
dee8370c Rafael J. Wysocki 2012-11-02 725 }
dee8370c Rafael J. Wysocki 2012-11-02 726
dee8370c Rafael J. Wysocki 2012-11-02 727 /**
6909f7ad Rafael J. Wysocki 2017-06-19 728 * __acpi_pm_device_wakeup - Enable/disable remote wakeup for given device.
9f7d805b Rafael J. Wysocki 2017-06-19 729 * @dev: Device to enable/disable to generate wakeup events.
dee8370c Rafael J. Wysocki 2012-11-02 730 * @enable: Whether to enable or disable the wakeup functionality.
cd7bd02d Rafael J. Wysocki 2012-11-02 731 */
6909f7ad Rafael J. Wysocki 2017-06-19 732 int __acpi_pm_device_wakeup(struct device *dev, bool enable, bool refcount)
a6ae7594 Rafael J. Wysocki 2012-11-02 733 {
a6ae7594 Rafael J. Wysocki 2012-11-02 734 struct acpi_device *adev;
a6ae7594 Rafael J. Wysocki 2012-11-02 @735 int error;
a6ae7594 Rafael J. Wysocki 2012-11-02 736
17653a3e Rafael J. Wysocki 2014-07-23 737 adev = ACPI_COMPANION(dev);
17653a3e Rafael J. Wysocki 2014-07-23 738 if (!adev) {
17653a3e Rafael J. Wysocki 2014-07-23 739 dev_dbg(dev, "ACPI companion missing in %s!\n", __func__);
a6ae7594 Rafael J. Wysocki 2012-11-02 740 return -ENODEV;
a6ae7594 Rafael J. Wysocki 2012-11-02 741 }
a6ae7594 Rafael J. Wysocki 2012-11-02 742
9f7d805b Rafael J. Wysocki 2017-06-19 743 if (!acpi_device_can_wakeup(adev))

:::::: The code at line 735 was first introduced by commit
:::::: a6ae7594b1b157e0e7976ed105a7be27d69a5361 ACPI / PM: Move device PM functions related to sleep states

:::::: TO: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
:::::: CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2017-06-20 14:39    [W:0.141 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site