Messages in this thread | | | From | Baolin Wang <> | Date | Wed, 21 Jun 2017 10:35:56 +0800 | Subject | Re: [PATCH v2 1/2] DT: pinctrl: Add binding documentation for Spreadtrum pin controller |
| |
On 20 June 2017 at 17:10, Linus Walleij <linus.walleij@linaro.org> wrote: > On Mon, Jun 12, 2017 at 8:07 AM, Baolin Wang <baolin.wang@spreadtrum.com> wrote: > >> I agree we should add these into core code, something like: >> static const struct pinconf_generic_params dt_params[] = { > (...) >> { "slew-rate", PIN_CONFIG_SLEW_RATE, 0 }, >> + { "sleep-bias-pull-up", PIN_CONFIG_SLEEP_BIAS_PULL_UP, 1}, >> + { "sleep-bias-pull-down", PIN_CONFIG_SLEEP_BIAS_PULL_DOWN 1}, >> ...... >> }; >> >> If you agree that, I can help to add these configuration. > > Actually, yes indeed, that is a nice thing. Very nice. I think my Nomadik > driver could use this too. > > Just need to hear what the DT maintainers have to say about it.
OK, I will submit one patch to review. Thanks.
-- Baolin.wang Best Regards
| |