lkml.org 
[lkml]   [2017]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data
From
From: Felix Manlunas <felix.manlunas@cavium.com>
Date: Tue, 20 Jun 2017 13:51:25 -0700

> From: Derek Chickles <Derek.Chickles@cavium.com>
> Date: Tue, 20 Jun 2017 13:15:34 -0700
>
>> > From: David Miller [mailto:davem@davemloft.net]
>> > Sent: Tuesday, June 20, 2017 12:22 PM
>> >
>> > From: Denys Vlasenko <dvlasenk@redhat.com>
>> > Date: Mon, 19 Jun 2017 21:50:52 +0200
>> >
>> > > Only compile-tested - I don't have the hardware.
>> > >
>> > > From code inspection, octeon_pci_write_core_mem() appears to be safe wrt
>> > > unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned
>> > > anyway.
>> > >
>> > > Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
>> >
>> > Looks good to me but I'll let one of the liquidio guys review this first
>> > before I apply it.
>>
>> Felix is going to try this out this week to confirm. Let's wait for his ack.
>
> This patch works. I tested it with a LiquidIO II adapter.
>
> ACK

Please ACK patches in the standard way which is in the form of:

Acked-by: David S. Miller <davem@davemloft.net>

This tag is recognized by tools and in particular the patchwork
site where networking patches are maintained, automatically
including your ACK into the patch I apply.

\
 
 \ /
  Last update: 2017-06-21 03:18    [W:0.553 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site