Messages in this thread | | | Subject | Re: [PATCH v5 3/7] selftests/seccomp: Force rebuild according to dependencies | From | Shuah Khan <> | Date | Fri, 2 Jun 2017 13:31:50 -0600 |
| |
Hi Mickaël,
On 05/26/2017 12:43 PM, Mickaël Salaün wrote: > Rebuild the seccomp tests when kselftest_harness.h is updated. > > Signed-off-by: Mickaël Salaün <mic@digikod.net> > Acked-by: Kees Cook <keescook@chromium.org> > Cc: Andy Lutomirski <luto@amacapital.net> > Cc: Shuah Khan <shuah@kernel.org> > Cc: Will Drewry <wad@chromium.org> > --- > tools/testing/selftests/seccomp/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/selftests/seccomp/Makefile > index 5fa6fd2246b1..aeb0c805f3ca 100644 > --- a/tools/testing/selftests/seccomp/Makefile > +++ b/tools/testing/selftests/seccomp/Makefile > @@ -4,3 +4,5 @@ LDFLAGS += -lpthread > > include ../lib.mk > > +$(TEST_GEN_PROGS): seccomp_bpf.c ../kselftest_harness.h > + $(CC) $(CFLAGS) $(LDFLAGS) $< -o $@ >
This change breaks seccomp build:
make -C tools/testing/selftests/seccomp/ make: Entering directory '/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp' make: *** No rule to make target '../kselftest_harness.h', needed by '/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp/seccomp_bpf'. Stop. make: Leaving directory '/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp' shuah@mazurka:/mnt/data/lkml/linux_4.12$ cd tools/testing/selftests/seccomp/ shuah@mazurka:/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp$ make make: *** No rule to make target '../kselftest_harness.h', needed by '/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp/seccomp_bpf'. Stop.
Did you happen to try building with this change?
thanks, -- Shuah
| |