Messages in this thread | | | Date | Fri, 2 Jun 2017 11:35:26 -0700 (PDT) | From | Stefano Stabellini <> | Subject | Re: [PATCH v2 07/18] xen/pvcalls: implement socket command |
| |
On Fri, 26 May 2017, Boris Ostrovsky wrote: > > static int pvcalls_back_socket(struct xenbus_device *dev, > > struct xen_pvcalls_request *req) > > { > > - return 0; > > + struct pvcalls_back_priv *priv; > > + int ret; > > + struct xen_pvcalls_response *rsp; > > + > > + priv = dev_get_drvdata(&dev->dev); > > + > > + if (req->u.socket.domain != AF_INET || > > + req->u.socket.type != SOCK_STREAM || > > + (req->u.socket.protocol != 0 && > > + req->u.socket.protocol != AF_INET)) > > Shouldn't this be one of IPPROTO_* macros?
Ah yes, I could use IPPROTO_IP instead of 0 here
| |