Messages in this thread | | | Date | Mon, 19 Jun 2017 18:09:58 +0200 (CEST) | From | Miroslav Benes <> | Subject | Re: [PATCH 1/3] livepatch: introduce shadow variable API |
| |
> > +struct klp_shadow { > > + struct hlist_node node; > > + struct rcu_head rcu_head; > > + void *obj; > > + char *var; > > + void *data; > > I would make the meaning more obvious. What about renaming? > > var -> key or id > data -> shadow_obj or new_obj
But var is not a key to a hash table. obj is. Renaming obj to key would be misleading in my opinion, because it IS a pointer to an object. And data is ok too, as far as I'm concerned. Just saying.
But yes, I'd welcome a description too.
Miroslav
| |