lkml.org 
[lkml]   [2017]   [Jun]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] livepatch: introduce shadow variable API

> > +struct klp_shadow {
> > + struct hlist_node node;
> > + struct rcu_head rcu_head;
> > + void *obj;
> > + char *var;
> > + void *data;
>
> I would make the meaning more obvious. What about renaming?
>
> var -> key or id
> data -> shadow_obj or new_obj

But var is not a key to a hash table. obj is. Renaming obj to key would be
misleading in my opinion, because it IS a pointer to an object. And data
is ok too, as far as I'm concerned. Just saying.

But yes, I'd welcome a description too.

Miroslav

\
 
 \ /
  Last update: 2017-06-19 18:11    [W:0.093 / U:1.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site