Messages in this thread | | | From | Salil Mehta <> | Subject | RE: [PATCH V2 net-next 2/8] net: hns3: Add support of the HNAE3 framework | Date | Sat, 17 Jun 2017 11:18:49 +0000 |
| |
Hi Andrew,
> -----Original Message----- > From: Andrew Lunn [mailto:andrew@lunn.ch] > Sent: Wednesday, June 14, 2017 2:38 AM > To: Salil Mehta > Cc: davem@davemloft.net; Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V2 net-next 2/8] net: hns3: Add support of the > HNAE3 framework > > On Wed, Jun 14, 2017 at 12:10:29AM +0100, Salil Mehta wrote: > > +static int __init hnae3_init(void) > > +{ > > + return 0; > > +} > > + > > .. > > > +subsys_initcall(hnae3_init); > > And the point of this is? > > Andrew This looks weird but not sure how we could have made sure HNAE is available before other 2 drivers could have loaded. Changing into module_init() means two other modules (dependent upon hnae) if loaded first will experience load time linking problems. Do you think this is okay?
Thanks Salil
| |