lkml.org 
[lkml]   [2017]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH] i2c: tc358743: remove useless variable assignment in tc358743_isr
Date
Thanks!
You could remove

intstatus &= ~MASK_HDMI_INT;

in line 1289 as well.

Regards,
Mats Randgaard

On 15/06/2017, 18:49, "Gustavo A. R. Silva" <garsilva@embeddedor.com> wrote:

Remove useless variable assignment in function tc358743_isr().

The value stored in variable _intstatus_ at line 1299 is
overwritten at line 1302, just before it can be used.

Addresses-Coverity-ID: 1397678
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/media/i2c/tc358743.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index 3251cba..e8b23f3 100644
--- a/drivers/media/i2c/tc358743.c
+++ b/drivers/media/i2c/tc358743.c
@@ -1296,7 +1296,6 @@ static int tc358743_isr(struct v4l2_subdev *sd, u32 status, bool *handled)
tc358743_csi_err_int_handler(sd, handled);

i2c_wr16(sd, INTSTATUS, MASK_CSI_INT);
- intstatus &= ~MASK_CSI_INT;
}

intstatus = i2c_rd16(sd, INTSTATUS);
--
2.5.0


\
 
 \ /
  Last update: 2017-06-16 09:39    [W:0.937 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site