Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 16 Jun 2017 09:18:38 +0200 | Subject | Re: [PATCH 04/04] iommu/ipmmu-vmsa: Replace local utlb code with fwspec ids |
| |
Hi Magnus,
On Thu, Jun 15, 2017 at 12:29 PM, Magnus Damm <magnus.damm@gmail.com> wrote: > Now when both 32-bit and 64-bit code inside the driver is using > fwspec it is possible to replace the utlb handling with fwspec ids > that get populated from ->of_xlate().
Thanks for your patch!
> --- 0013/drivers/iommu/ipmmu-vmsa.c > +++ work/drivers/iommu/ipmmu-vmsa.c 2017-06-15 18:32:27.580607110 +0900
> static int ipmmu_of_xlate(struct device *dev, > struct of_phandle_args *spec) > { > - return ipmmu_init_platform_device(dev); > + iommu_fwspec_add_ids(dev, spec->args, 1);
Does it hurt if iommu_fwspec_add_ids() is called multiple times, as this is done before the "Initialize once - xlate() will call multiple times" check?
> + > + return ipmmu_init_platform_device(dev, spec); > }
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |