Messages in this thread | | | Subject | Re: [PATCH 6/6] ARM: dts: rockchip: add efuse device node for rk3228 | From | Frank Wang <> | Date | Fri, 16 Jun 2017 17:24:23 +0800 |
| |
Hi Heiko,
On 2017/6/15 23:10, Heiko Stuebner wrote: > Hi Frank, > > Am Donnerstag, 15. Juni 2017, 15:23:16 CEST schrieb Frank Wang: >> From: Finley Xiao <finley.xiao@rock-chips.com> >> >> Add a efuse node in the device tree for the rk3228 SoC. >> >> Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com> >> --- >> arch/arm/boot/dts/rk322x.dtsi | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi >> index c2a78f4..dad195e 100644 >> --- a/arch/arm/boot/dts/rk322x.dtsi >> +++ b/arch/arm/boot/dts/rk322x.dtsi >> @@ -314,6 +314,23 @@ >> status = "disabled"; >> }; >> >> + efuse: efuse@11040000 { >> + compatible = "rockchip,rk322x-efuse"; > was this binding included already? Simply because compatibles should > not contain placeholders, so rockchip,rk3228-efuse please - same for > the driver side.
Actually, I always remember it should be without placeholders from the first time you commented :-) but I saw that the binding and driver (rockchip,rk322x-efuse) have already been applied, so I send this one keep the same with driver side. Shall I resend a new patch to correct both of them to 'rockchip,rk3228-efuse' ?
BR. Frank
> > Heiko > > >> + reg = <0x11040000 0x20>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + clocks = <&cru PCLK_EFUSE_256>; >> + clock-names = "pclk_efuse"; >> + >> + /* Data cells */ >> + efuse_id: id@7 { >> + reg = <0x7 0x10>; >> + }; >> + cpu_leakage: cpu_leakage@17 { >> + reg = <0x17 0x1>; >> + }; >> + }; >> + >> i2c0: i2c@11050000 { >> compatible = "rockchip,rk3228-i2c"; >> reg = <0x11050000 0x1000>; >>
| |