Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 16 Jun 2017 11:16:32 +0200 | Subject | Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage |
| |
On Fri, Jun 9, 2017 at 12:09 PM, Gregory CLEMENT <gregory.clement@free-electrons.com> wrote:
> In some place in the driver regmap_update_bits was misused. Indeed the > last argument is not the value of the bit (or group of bits) itself but > the mask value inside the register. > > So when setting the bit N, then the value must be BIT(N) and not 1. > > CC: Chris Packham <Chris.Packham@alliedtelesis.co.nz> > CC: Ralph Sennhauser <ralph.sennhauser@gmail.com> > Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> > --- > Hi, > > In this second version I fixed the improper changed pointed by Thomas.
This version applied with the tags.
Yours, Linus Walleij
| |