lkml.org 
[lkml]   [2017]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Qemu crashes in -next due to 'of: remove *phandle properties from expanded device tree'
From
Date
On 06/15/2017 12:58 AM, Frank Rowand wrote:
> On 06/14/17 21:12, Guenter Roeck wrote:
>
> < snip >
>
>> Good (v4.12-rc4):
>>
>
> < snip >
>
>> OF: Checking node /soc@e0000000/pic@40000
>> OF: type match
>> OF: node '/soc@e0000000/pic@40000' compatible '' type 'open-pic' name '' score 2
>> OF: node '/soc@e0000000/pic@40000' compatible 'open-pic' type '' name '' score 0
>
> < snip >
>
>>
>> bad:
>
> < snip >
>
>> OF: Checking node /soc@e0000000/pic@40000
>> OF: node '/soc@e0000000/pic@40000' compatible '' type 'open-pic' name '' score 0
>> OF: node '/soc@e0000000/pic@40000' compatible 'open-pic' type '' name '' score 0
>
> < snip >
>
>> No matching open-pic node
>> ------------[ cut here ]------------
>> kernel BUG at arch/powerpc/platforms/85xx/corenet_generic.c:50!
>>
>> So, in __of_device_is_compatible(), the difference is in
>> __of_device_is_compatible() after
>>
>> /* Matching type is better than matching name */
>>
>> Further debugging shows that device->type is NULL in the bad case.
>>
>> OF: Checking node /soc@e0000000/pic@40000
>> OF: trying type match open-pic - <NULL>
>> OF: node '/soc@e0000000/pic@40000' compatible '' type 'open-pic' name '' score 0
>> OF: node '/soc@e0000000/pic@40000' compatible 'open-pic' type '' name '' score 0
>>
>> Do you need more information ?
>
> I think I know what part of my patch is causing the problem.
>
> Can you try the following patch to see if if fixes the failure in
> __of_device_is_compatible()?
>
> If this fixes the failure, then I know what is going on. If it works
> then I will have to rework my original patch in a different way than
> this quick hack.
>

Sorry, doesn't make a difference.

OF: Checking node /soc@e0000000/pic@40000
OF: trying type match open-pic - <NULL>
OF: node '/soc@e0000000/pic@40000' compatible '' type 'open-pic' name '' score 0
OF: node '/soc@e0000000/pic@40000' compatible 'open-pic' type '' name '' score 0

I added a log message into __of_attach_node(); it is not called.

Guenter

\
 
 \ /
  Last update: 2017-06-15 11:55    [W:0.110 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site