lkml.org 
[lkml]   [2017]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 05/10] x86/mm: Rework lazy TLB mode and TLB freshness tracking
From
Date
On 06/13/2017 09:56 PM, Andy Lutomirski wrote:
> - if (cpumask_test_cpu(cpu, &batch->cpumask))
> + if (cpumask_test_cpu(cpu, &batch->cpumask)) {
> + local_irq_disable();
> flush_tlb_func_local(&info, TLB_LOCAL_SHOOTDOWN);
> + local_irq_enable();
> + }
> +

Could you talk a little about why this needs to be local_irq_disable()
and not preempt_disable()? Is it about the case where somebody is
trying to call flush_tlb_func_*() from an interrupt handler?

\
 
 \ /
  Last update: 2017-06-15 00:34    [W:0.244 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site