lkml.org 
[lkml]   [2017]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 2/4] xen: add sysfs node for guest type
From
Date

> diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c
> index 84106f9c456c..d641e9970d5d 100644
> --- a/drivers/xen/sys-hypervisor.c
> +++ b/drivers/xen/sys-hypervisor.c
> @@ -50,6 +50,18 @@ static int __init xen_sysfs_type_init(void)
> return sysfs_create_file(hypervisor_kobj, &type_attr.attr);
> }
>
> +static ssize_t guest_type_show(struct hyp_sysfs_attr *attr, char *buffer)
> +{
> + return sprintf(buffer, "%s\n", xen_guest_type);
> +}


So I know I gave my R-b for this patch but can't we just key off
xen_domain_type and not have xen_guest_type at all?

-boris

\
 
 \ /
  Last update: 2017-06-14 16:50    [W:0.727 / U:1.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site