lkml.org 
[lkml]   [2017]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] af_iucv: Move sockaddr length checks to before accessing sa_family in bind and connect handlers
From
From: Mateusz Jurczyk <mjurczyk@google.com>
Date: Tue, 13 Jun 2017 19:42:28 +0200

> Verify that the caller-provided sockaddr structure is large enough to
> contain the sa_family field, before accessing it in bind() and connect()
> handlers of the AF_IUCV socket. Since neither syscall enforces a minimum
> size of the corresponding memory region, very short sockaddrs (zero or
> one byte long) result in operating on uninitialized memory while
> referencing .sa_family.
>
> Signed-off-by: Mateusz Jurczyk <mjurczyk@google.com>
...
> /* Verify the input sockaddr */
> - if (!addr || addr->sa_family != AF_IUCV)
> - return -EINVAL;
> -
> - if (addr_len < sizeof(struct sockaddr_iucv))
> + if (!addr || addr_len < sizeof(struct sockaddr_iucv) ||
> + addr->sa_family != AF_IUCV)

The 'addr' can never be NULL so please remove that check, thank you.

\
 
 \ /
  Last update: 2017-06-13 22:16    [W:0.034 / U:3.436 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site