| Date | Tue, 13 Jun 2017 20:54:36 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH v4 12/16] perf header: add a buffer to struct feat_fd |
| |
On Mon, Jun 12, 2017 at 09:29:28PM -0700, David Carrillo-Cisneros wrote:
SNIP
> /* Return: 0 if succeded, -ERR if failed. */ > int write_padded(struct feat_fd *ff, const void *bf, > size_t count, size_t count_aligned) > @@ -125,13 +151,32 @@ static int do_write_string(struct feat_fd *ff, const char *str) > return write_padded(ff, str, olen, len); > } > > -static int __do_read(struct feat_fd *ff, void *addr, ssize_t size) > +static int __do_read_fd(struct feat_fd *ff, void *addr, ssize_t size) > { > - ssize_t ret = readn(ff->fd, addr, size); > + ssize_t ret = readn(ff->fd, addr, size); > + > + if (ret != size) > + return ret < 0 ? (int)ret : -1; > + return 0;
extra tab in indent
jirka
|