Messages in this thread | | | Date | Tue, 13 Jun 2017 11:48:41 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code |
| |
On Tue, Jun 06, 2017 at 12:27:04PM +0100, Alan Cox wrote: > On Tue, 6 Jun 2017 12:54:40 +0200 > Johan Hovold <johan@kernel.org> wrote: > > > Remove three ifdefed and broken implementations of TIOCSSERIAL and > > TIOCGICOUNT, and parity handling in set_termios which had suffered > > severe bit rot. > > I would be amazed if the IRDA code still works. It's not been tested > properly for years and it never followed the tty rules properly in the > first place - so this looks good, although moving IRDA into staging > and /dev/null would IMHO be far better. > > IRDA is dead, and IR remotes are handled via completely different code.
I agree, and we should move it into staging and out of the tree, I'll send netdev some patches for that...
thanks,
greg k-h
| |