lkml.org 
[lkml]   [2017]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.11 007/150] tcp: disallow cwnd undo when switching congestion control
    Date
    4.11-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Yuchung Cheng <ycheng@google.com>


    [ Upstream commit 44abafc4cc094214a99f860f778c48ecb23422fc ]

    When the sender switches its congestion control during loss
    recovery, if the recovery is spurious then it may incorrectly
    revert cwnd and ssthresh to the older values set by a previous
    congestion control. Consider a congestion control (like BBR)
    that does not use ssthresh and keeps it infinite: the connection
    may incorrectly revert cwnd to an infinite value when switching
    from BBR to another congestion control.

    This patch fixes it by disallowing such cwnd undo operation
    upon switching congestion control. Note that undo_marker
    is not reset s.t. the packets that were incorrectly marked
    lost would be corrected. We only avoid undoing the cwnd in
    tcp_undo_cwnd_reduction().

    Signed-off-by: Yuchung Cheng <ycheng@google.com>
    Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
    Signed-off-by: Neal Cardwell <ncardwell@google.com>
    Signed-off-by: Eric Dumazet <edumazet@google.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/ipv4/tcp_cong.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/ipv4/tcp_cong.c
    +++ b/net/ipv4/tcp_cong.c
    @@ -180,6 +180,7 @@ void tcp_init_congestion_control(struct
    {
    const struct inet_connection_sock *icsk = inet_csk(sk);

    + tcp_sk(sk)->prior_ssthresh = 0;
    if (icsk->icsk_ca_ops->init)
    icsk->icsk_ca_ops->init(sk);
    if (tcp_ca_needs_ecn(sk))

    \
     
     \ /
      Last update: 2017-06-12 20:57    [W:7.187 / U:0.572 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site