lkml.org 
[lkml]   [2017]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 113/119] tracing: Use strlcpy() instead of strcpy() in __trace_find_cmdline()
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Amey Telawane <ameyt@codeaurora.org>

    commit e09e28671cda63e6308b31798b997639120e2a21 upstream.

    Strcpy is inherently not safe, and strlcpy() should be used instead.
    __trace_find_cmdline() uses strcpy() because the comms saved must have a
    terminating nul character, but it doesn't hurt to add the extra protection
    of using strlcpy() instead of strcpy().

    Link: http://lkml.kernel.org/r/1493806274-13936-1-git-send-email-amit.pundir@linaro.org

    Signed-off-by: Amey Telawane <ameyt@codeaurora.org>
    [AmitP: Cherry-picked this commit from CodeAurora kernel/msm-3.10
    https://source.codeaurora.org/quic/la/kernel/msm-3.10/commit/?id=2161ae9a70b12cf18ac8e5952a20161ffbccb477]
    Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
    [ Updated change log and removed the "- 1" from len parameter ]
    Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    kernel/trace/trace.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/kernel/trace/trace.c
    +++ b/kernel/trace/trace.c
    @@ -1862,7 +1862,7 @@ static void __trace_find_cmdline(int pid

    map = savedcmd->map_pid_to_cmdline[pid];
    if (map != NO_CMDLINE_MAP)
    - strcpy(comm, get_saved_cmdlines(map));
    + strlcpy(comm, get_saved_cmdlines(map), TASK_COMM_LEN);
    else
    strcpy(comm, "<...>");
    }

    \
     
     \ /
      Last update: 2017-06-12 18:24    [W:5.484 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site