Messages in this thread | | | From | "Mani, Rajmohan" <> | Subject | RE: [PATCH v2 2/3] gpio: Add support for TPS68470 GPIOs | Date | Mon, 12 Jun 2017 09:14:16 +0000 |
| |
Hi Andy,
> Subject: Re: [PATCH v2 2/3] gpio: Add support for TPS68470 GPIOs > > On Sun, Jun 11, 2017 at 9:09 AM, Rajmohan Mani > <rajmohan.mani@intel.com> wrote: > > This patch adds support for TPS68470 GPIOs. > > There are 7 GPIOs and a few sensor related GPIOs. > > These GPIOs can be requested and configured as appropriate. > > Main points (some I already told in an answer to Sakari's mail): > 1. Consider 2 GPIO chips over 1.
I am looking into this.
> 2. Fix FIXME(s).
Leaving this on, until I see how this can be fixed.
> 3. If there is hardware bug we should work around it must be clarified.
Ack If this is about initializing the GPIOs with zero, I have removed this code for now.
> 4. You missed Linus' comments here (switch to the data pointer inside GPIO > chip and remove platform driver data stuff from the driver). >
I have fixed this with v3
| |