lkml.org 
[lkml]   [2017]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [10/10] Staging: rtl8712: ieee80211: fixed coding style issue
On Mon, Jun 12, 2017 at 12:14:06AM +0530, Jaya Durga wrote:
> Fixed WARNING: line over 80 characters
>
> Signed-off-by: Jaya Durga <jayad@cdac.in>
> ---
> drivers/staging/rtl8712/ieee80211.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --
> 1.9.1
>
> diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
> index 6e673c1..97ef063 100644
> --- a/drivers/staging/rtl8712/ieee80211.c
> +++ b/drivers/staging/rtl8712/ieee80211.c
> @@ -174,8 +174,8 @@ int r8712_generate_ie(struct registry_priv *pregistrypriv)
> sz += 8;
> ie += sz;
> /*beacon interval : 2bytes*/
> - *(__le16 *)ie = cpu_to_le16(
> - (u16)pdev_network->configuration.beacon_period);
> + struct NDIS_802_11_CONFIGURATION *cfg = &pdev_network->configuration;
> + *(__le16 *)ie = cpu_to_le16(cfg->beacon_period);

Do you really think that the resulting

drivers/staging/rtl8712/ieee80211.c:177:2: warning:
ISO C90 forbids mixed declarations and code

is better ?

Guenter

> sz += 2;
> ie += 2;
> /*capability info*/

\
 
 \ /
  Last update: 2017-06-12 23:25    [W:0.070 / U:1.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site