Messages in this thread | | | From | Al Cooper <> | Date | Mon, 12 Jun 2017 16:53:12 -0400 | Subject | Re: [PATCH 2/3] dt-bindings: Add Broadcom STB USB PHY binding document |
| |
On Mon, Jun 12, 2017 at 4:19 PM, Al Cooper <al.cooper@broadcom.com> wrote: > On Thu, Jun 8, 2017 at 6:11 PM, Rob Herring <robh@kernel.org> wrote: >>> +- brcm,device: String, PHY Device mode. >>> + Possible values are: off (Host), on (Device), dual (DRD) >>> + or typec-pd (Type-C PD control) >> >> I believe we have standard property for this though maybe not type C. >> >> off/on seem strange for meaning host/device as well. > > I'll change this to: > > mode: String, PHY Device mode. > Possible values are: "host", "device", "drd" or "typec-pd"
I just found "dr_mode" in Documentation/devicetree/bindings/usb/generic.txt. I'd like to change this to:
dr_mode: String, PHY Device mode. Possible values are: "host", "device", "drd" or "typec-pd"
I used a standard property name ("dr_mode") and 2 of the standard values ("host", "device") and added 2 new values "drd" and "typec_pd".
Thanks Al
| |