lkml.org 
[lkml]   [2017]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 15/16] tty: serdev: use dev_groups and not dev_attrs for bus_type
On Sat, Jun 10, 2017 at 10:01:22AM +1000, Stephen Rothwell wrote:
> Hi Greg,
>
> On Sat, 10 Jun 2017 09:56:49 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > > +static struct attribute *serdev_device_attrs[] = {
> > ^^^^^^^^^^^^^^^^^^^
> > Should have been "serdev_device_groups"
>
> Sorry, my mistake.
>
> > > + &dev_attr_modalias.attr,
> > > + NULL,
> > > };
> > > +ATTRIBUTE_GROUPS(serdev_device);
>
> I really hate macros that create symbols by concatenating parts. :-(

I totally agree, but it's the only way I could come up with at the time
to make this type of macro to simplify a lot of boiler-plate code.

sorry,

greg k-h

\
 
 \ /
  Last update: 2017-06-12 01:55    [W:0.050 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site