Messages in this thread Patch in this message | | | From | Ben Hutchings <> | Date | Thu, 01 Jun 2017 16:43:16 +0100 | Subject | [PATCH 3.16 085/212] bcma: use (get|put)_device when probing/removing device driver |
| |
3.16.44-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: Rafał Miłecki <rafal@milecki.pl>
commit a971df0b9d04674e325346c17de9a895425ca5e1 upstream.
This allows tracking device state and e.g. makes devm work as expected.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl> Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Signed-off-by: Ben Hutchings <ben@decadent.org.uk> --- drivers/bcma/main.c | 4 ++++ 1 file changed, 4 insertions(+)
--- a/drivers/bcma/main.c +++ b/drivers/bcma/main.c @@ -450,8 +450,11 @@ static int bcma_device_probe(struct devi drv); int err = 0; + get_device(dev); if (adrv->probe) err = adrv->probe(core); + if (err) + put_device(dev); return err; } @@ -464,6 +467,7 @@ static int bcma_device_remove(struct dev if (adrv->remove) adrv->remove(core); + put_device(dev); return 0; }
| |