lkml.org 
[lkml]   [2017]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 198/212] net: ipv6: check route protocol when deleting routes
    3.16.44-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mantas M <grawity@gmail.com>

    commit c2ed1880fd61a998e3ce40254a99a2ad000f1a7d upstream.

    The protocol field is checked when deleting IPv4 routes, but ignored for
    IPv6, which causes problems with routing daemons accidentally deleting
    externally set routes (observed by multiple bird6 users).

    This can be verified using `ip -6 route del <prefix> proto something`.

    Signed-off-by: Mantas Mikulėnas <grawity@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    net/ipv6/route.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/net/ipv6/route.c
    +++ b/net/ipv6/route.c
    @@ -1733,6 +1733,8 @@ static int ip6_route_del(struct fib6_con
    continue;
    if (cfg->fc_metric && cfg->fc_metric != rt->rt6i_metric)
    continue;
    + if (cfg->fc_protocol && cfg->fc_protocol != rt->rt6i_protocol)
    + continue;
    dst_hold(&rt->dst);
    read_unlock_bh(&table->tb6_lock);

    \
     
     \ /
      Last update: 2017-06-01 17:54    [W:4.501 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site