Messages in this thread | | | From | Andy Shevchenko <> | Date | Thu, 1 Jun 2017 16:16:05 +0300 | Subject | Re: [PATCH] firmware: dmi: Check DMI structure length |
| |
On Thu, Jun 1, 2017 at 4:08 PM, Jean Delvare <jdelvare@suse.de> wrote: > Before accessing DMI data to record it for later, we should ensure > that the DMI structures are large enough to contain the data in > question.
> - const u8 *d = (u8 *) dm + index; > + const u8 *d;
> + d = (u8 *) dm + index;
I think you may leave this as is and make it compiler's burden to optimize.
> - const u8 *d = (u8 *) dm + index; > + const u8 *d;
> + d = (u8 *) dm + index;
Ditto.
> - int i, count = *(u8 *)(dm + 1); > + int i, count;
> + count = *(u8 *)(dm + 1);
Ditto.
-- With Best Regards, Andy Shevchenko
| |