Messages in this thread | | | Date | Thu, 1 Jun 2017 15:10:20 +0200 | From | Peter Zijlstra <> | Subject | Re: [RFC PATCH 10/10] x86/unwind: add undwarf unwinder |
| |
On Thu, Jun 01, 2017 at 07:26:51AM -0500, Josh Poimboeuf wrote: > On Thu, Jun 01, 2017 at 01:05:39PM +0200, Peter Zijlstra wrote: > > On Thu, Jun 01, 2017 at 12:44:16AM -0500, Josh Poimboeuf wrote: > > > > > +static struct undwarf *__undwarf_lookup(struct undwarf *undwarf, > > > + unsigned int num, unsigned long ip) > > > +{ > > > + struct undwarf *first = undwarf; > > > + struct undwarf *last = undwarf + num - 1; > > > + struct undwarf *mid; > > > + unsigned long u_ip; > > > + > > > + while (first <= last) { > > > + mid = first + ((last - first) / 2); > > > + u_ip = undwarf_ip(mid); > > > + > > > + if (ip >= u_ip) { > > > + if (ip < u_ip + mid->len) > > > + return mid; > > > + first = mid + 1; > > > + } else > > > + last = mid - 1; > > > + } > > > + > > > + return NULL; > > > +} > > > > That's a bog standard binary search thing, don't we have a helper for > > that someplace? > > I wasn't able to find one...
Yeah, I looked too and couldn't find it either. A well.
| |