Messages in this thread | | | Date | Thu, 1 Jun 2017 12:21:39 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given |
| |
On Thu, Jun 01, 2017 at 05:03:21PM +0800, changbin.du@intel.com wrote: > From: Changbin Du <changbin.du@intel.com> > > If we always insert 'overhead' and 'overhead_children' as sort keys, > this make it impossible to sort as overhead (which displayed as Self) > first.Ths will be a problem if the data is collected with call-graph > enabled. Then we never can sort the result as self-overhead on this > data. And sometimes the data is hard to collect. > > This patch fix this by only insert overhead && overhead_children > when no overhead* field given. > > Signed-off-by: Changbin Du <changbin.du@intel.com> > --- > tools/perf/util/sort.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c > index 5762ae4..69eea3a 100644 > --- a/tools/perf/util/sort.c > +++ b/tools/perf/util/sort.c > @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys) > if (sort__mode == SORT_MODE__DIFF) > return keys; > > + if (strstr(keys, "overhead")) > + return keys; > + > keys = prefix_if_not_in("overhead", keys);
hum, you basicaly do what's at begining of prefix_if_not_in function:
static char *prefix_if_not_in(const char *pre, char *str) { char *n;
if (!str || strstr(str, pre)) return str; ...
could you please provide the example described in changelog?
jirka
| |