lkml.org 
[lkml]   [2017]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Fix NR_IRQS printk()
On Tue, May 9, 2017 at 9:08 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Wed, 3 May 2017, Vincent Legoll wrote:
>
>> Subject : [PATCH] Fix NR_IRQS printk()
>
> The subject line is missing a subsystem token. Please consult
>
> Documentation/process/submitting-patches.rst
>
> and run 'git log path/to/affected.file' to see how a proper subject line
> should look like.

OK, looks like this is "genirq", is that right ?

>> - Missing some whitespace
>> - Tell that the third number is "initcnt" (whatever that is)
>
> Your changelog is telling WHAT the patch is doing, but not WHY and despite
> the subject claiming to fix something the changelog lacks any information
> about the problem it "fixes".

OK, will change, what about:
"[PATCH] genirq: Fix early_irq_init() printing the nr of preallocated irqs"

> Aside of that: "(whatever that is)" is not really convincing that you know
> what you are doing.

Is the above better ? If OK, I'll resend properly.

Thanks for the help

--
Vincent Legoll

\
 
 \ /
  Last update: 2017-05-10 21:17    [W:0.042 / U:11.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site