Messages in this thread | | | From | Vincent Legoll <> | Date | Tue, 9 May 2017 09:41:41 +0200 | Subject | Re: [PATCH] Fix NR_IRQS printk() |
| |
On Tue, May 9, 2017 at 9:08 AM, Thomas Gleixner <tglx@linutronix.de> wrote: > On Wed, 3 May 2017, Vincent Legoll wrote: > >> Subject : [PATCH] Fix NR_IRQS printk() > > The subject line is missing a subsystem token. Please consult > > Documentation/process/submitting-patches.rst > > and run 'git log path/to/affected.file' to see how a proper subject line > should look like.
OK, looks like this is "genirq", is that right ?
>> - Missing some whitespace >> - Tell that the third number is "initcnt" (whatever that is) > > Your changelog is telling WHAT the patch is doing, but not WHY and despite > the subject claiming to fix something the changelog lacks any information > about the problem it "fixes".
OK, will change, what about: "[PATCH] genirq: Fix early_irq_init() printing the nr of preallocated irqs"
> Aside of that: "(whatever that is)" is not really convincing that you know > what you are doing.
Is the above better ? If OK, I'll resend properly.
Thanks for the help
-- Vincent Legoll
| |