lkml.org 
[lkml]   [2017]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pinctrl: imx: Check for memory allocation failure
On Sun, May 07, 2017 at 04:40:38AM +0900, Stafford Horne wrote:
> Hi Christophe,
>
> On Sat, May 06, 2017 at 10:23:59AM +0200, Christophe JAILLET wrote:
> > If 'devm_kzalloc' fails, a NULL pointer will be dereferenced.
> > Return -ENOMEM instead, as done for the other memory allocation just a
> > few lines below.
>
> This looks fine.
>
> > BTW, change the 'devm_kzalloc' into a 'devm_kcalloc'.
>
> Any reason for the devm_kcalloc change? It looks like the next for loop
> does set all of the group_name values.
>

The advantage of kcalloc() over kzalloc() is the integer overflow
checking. There is kmalloc_array() if we don't need to zero the memory.

regards,
dan carpenter

\
 
 \ /
  Last update: 2017-05-10 21:17    [W:0.051 / U:2.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site