lkml.org 
[lkml]   [2017]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix NR_IRQS printk()
On Wed, 3 May 2017, Vincent Legoll wrote:

> Subject : [PATCH] Fix NR_IRQS printk()

The subject line is missing a subsystem token. Please consult

Documentation/process/submitting-patches.rst

and run 'git log path/to/affected.file' to see how a proper subject line
should look like.

> - Missing some whitespace
> - Tell that the third number is "initcnt" (whatever that is)

Your changelog is telling WHAT the patch is doing, but not WHY and despite
the subject claiming to fix something the changelog lacks any information
about the problem it "fixes".

Aside of that: "(whatever that is)" is not really convincing that you know
what you are doing.

Thanks,

tglx

\
 
 \ /
  Last update: 2017-05-10 21:17    [W:0.047 / U:14.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site